fix(controls): Check if UIElement is connected to presentation source#1533
Merged
pomianowski merged 3 commits intolepoco:mainfrom Nov 7, 2025
Merged
fix(controls): Check if UIElement is connected to presentation source#1533pomianowski merged 3 commits intolepoco:mainfrom
UIElement is connected to presentation source#1533pomianowski merged 3 commits intolepoco:mainfrom
Conversation
UIElement is connected to presentation source
pomianowski
approved these changes
Nov 7, 2025
This was referenced Nov 24, 2025
This was referenced Dec 2, 2025
This was referenced Dec 22, 2025
This was referenced Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
To call PointFromScreen, the visual needs to be connected to a presentation source. Otherwise an
InvalidOperationExceptionwith the messageThis Visual is not connected to a PresentationSourceis thrown. This is already catched, but we can avoid this by checking whether it's connected. I also refactored the almost unreadable panel fallback into a separate method.